Better handling of http(s).proxyUser and http(s).proxyPassword#123
Better handling of http(s).proxyUser and http(s).proxyPassword#123jborgland wants to merge 2 commits intoapache:4.5.xfrom
Conversation
| systemcreds = getProxyCredentials("http", authscope); | ||
| if (systemcreds == null) { | ||
| systemcreds = getProxyCredentials("https", authscope); | ||
| } |
There was a problem hiding this comment.
I haven't found any better solution yet, but this looks really redudant in most cases. Shouldn't it fall back for https => http only?
There was a problem hiding this comment.
You mean to only do it if protocol is http? Sure.
One could imagine other completely different types of fixes as well. I tried to make a fix that was completely local to the SystemDefaultCredentialsProvider but when it's called (from AuthenticationStrategyImpl) there's more information available - like the fact that it is in fact a proxy that we're connecting to, and the HTTP status code (one could for example decide to use these system properties as the primary source if the status code is 407).
There was a problem hiding this comment.
@jborgland Feel free to propose API changes in master
|
@jborgland The proposed change-set loos reasonable to me. Please do fix the style check violations and make sure the build is successful and all tests pass. |
|
@jborgland I will commit the change-set to 4.5.x and master as soon as HC 5.0-beta3 release has been closed. |
|
@ok2c thank you! Sorry about the Checkstyle warnings, I was in a bit of hurry and didn't pay attention to Checkstyle not working in my (brand new) environment. |
3 participants
Suggested fix for HTTPCLIENT-1955.